[PATCH] tools: Do not build kwbimage if CONFIG_TOOLS_LIBCRYPTO=n

[Marek Vasut]

On 1/11/22 17:16, Tom Rini wrote:
> On Tue, Jan 11, 2022 at 04:36:34PM +0100, Pali Rohár wrote:
>> On Tuesday 11 January 2022 16:31:20 Marek Vasut wrote:
>>> The kwbimage has hard dependency on OpenSSL, do not build it
>>> in case TOOLS_LIBCRYPTO is disabled.
>>
>> This patch does not work as kwbimage is required for 32-bit Armada
>> platforms. So kwbimage.o cannot be disabled on these platforms.
>>
>> There is already proposal for fixing this issue:
>> https://patchwork.ozlabs.org/project/uboot/patch/20211021093304.25399-1-pali@kernel.org/
> 
> And needs to be respun to not have Kconfig issues.  To answer something
> noted in that thread, yes, it would be good if Kconfig did, or had an
> option to make WARNING like that fatal.  Or is the problem really that
> no, it's non-optional, really, to have OpenSSL installed?

OpenSSL should be optional, I got this bug report where someone tried to 
build u-boot on ancient debian oldoldstable with openssl 1.1.0 (without 
ecdsa support), for a platform which doesn't need any of this crypto 
stuff. So, disabling TOOLS_LIBCRYPTO was a sufficient for that platform 
to build in that setup (with this patch). And there are plenty of such 
platforms in the U-Boot tree (all that are not marvell I think).