[PATCH v3] net: fsl: Fix busy flag polling register

Camelia Alexandra Groza (OSS) camelia.groza at oss.nxp.com
Wed Jan 12 11:50:06 CET 2022


> -----Original Message-----
> From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Markus Koch
> Sent: Tuesday, January 11, 2022 20:23
> To: Camelia Alexandra Groza <camelia.groza at nxp.com>;
> joe.hershberger at ni.com; rfried.dev at gmail.com
> Cc: Madalin Bucur (OSS) <madalin.bucur at oss.nxp.com>; Ioana Ciornei
> <ioana.ciornei at nxp.com>; u-boot at lists.denx.de; Markus Koch
> <markus at notsyncing.net>
> Subject: [PATCH v3] net: fsl: Fix busy flag polling register
> 
> NXP's mEMAC reference manual, Chapter 6.5.5 "MDIO Ethernet
> Management
> Interface usage", specifies to poll the BSY (0) bit in the CFG/STAT
> register to wait until a transaction has finished, not bit 31 in the
> data register.
> 
> In the Linux kernel, this has already been fixed in commit 26eee0210ad7
> ("net/fsl: fix a bug in xgmac_mdio").
> 
> This patch changes the register in the fman_mdio and fsl_ls_mdio
> drivers.
> 
> As the MDIO_DATA_BSY define is no longer in use, this patch also removes
> its definition from the fsl_memac header.
> 
> Signed-off-by: Markus Koch <markus at notsyncing.net>
> ---
> v1->v2:
> 	* Fix register
> v2->v3:
> 	* Also apply fix to fsl_ls_mdio
> 	* Add note about define-removal in commit message
> 
> Thanks, Camelia!

Thanks for the patch.

Reviewed-by: Camelia Groza <camelia.groza at nxp.com>



More information about the U-Boot mailing list