[RFC 4/6] mmc: exynos_dw_mmc: remove the error message and not return

Jaehoon Chung jh80.chung at samsung.com
Thu Jan 13 09:39:26 CET 2022


Remove error message and not return when there is error value.
After checked whether error is or not, if be, use default value.

Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
---
 drivers/mmc/exynos_dw_mmc.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c
index 526c30d2fe0f..49e57f695029 100644
--- a/drivers/mmc/exynos_dw_mmc.c
+++ b/drivers/mmc/exynos_dw_mmc.c
@@ -182,18 +182,12 @@ static int exynos_dwmci_get_config(const void *blob, int node,
 
 	/* Extract the timing info from the node */
 	err =  fdtdec_get_int_array(blob, node, "samsung,timing", timing, 3);
-	if (err) {
-		printf("DWMMC%d: Can't get sdr-timings for devider\n",
-				host->dev_index);
-		return -EINVAL;
-	}
-
 	priv->sdr_timing = (DWMCI_SET_SAMPLE_CLK(timing[0]) |
 			DWMCI_SET_DRV_CLK(timing[1]) |
 			DWMCI_SET_DIV_RATIO(timing[2]));
 
 	/* sdr_timing didn't assigned anything, use the default value */
-	if (!priv->sdr_timing) {
+	if (err || !priv->sdr_timing) {
 		if (host->dev_index == 0)
 			priv->sdr_timing = DWMMC_MMC0_SDR_TIMING_VAL;
 		else if (host->dev_index == 2)
-- 
2.29.0



More information about the U-Boot mailing list