[PATCH 3/4] arm64: dts: imx8mm-u-boot.dtsi: fix typo in ddr blob name

Michael Walle michael at walle.cc
Thu Jan 13 14:29:50 CET 2022


Am 2022-01-13 14:16, schrieb Patrick Wildt:
> On Thu, Jan 13, 2022 at 12:42:50PM +0100, Michael Walle wrote:
>> Hi,
>> 
>> > --- a/arch/arm/dts/imx8mm-u-boot.dtsi
>> > +++ b/arch/arm/dts/imx8mm-u-boot.dtsi
>> > @@ -39,7 +39,7 @@
>> >  			filename = "u-boot-spl.bin";
>> >  		};
>> >
>> > -		1d-imem {
>> > +		1d_imem {
>> 
>> I think it is the other way around. Device tree node names should 
>> contain
>> hyphens and not underscores.
>> 
>> I couldn't find any references in dtschema though. Maybe I haven't 
>> looked
>> hard enough.
>> 
>> But you can see linux commit 28d7f0f3f10b, for example.
>> 
>> -michael
> 
> Hi,
> 
> I don't know what's right, but every other of these in the i.MX8MM file
> use _ instead of -, so if at all this makes it consistenly wrong, but
> at least now it's consistent. ;)
> 
> If it's wrong, I'm sure someone will step up and rectify it.

Why don't you just change it to the correct naming then?

-michael


More information about the U-Boot mailing list