[PATCH v2 4/8] arm: kirkwood: Pogoplug-V4 : Add board include configs file

[Tony Dinh]

Hi Tom,

On Thu, Jan 13, 2022 at 5:36 AM Tom Rini <trini at konsulko.com> wrote:
>
> On Thu, Jan 13, 2022 at 02:32:00PM +0100, Stefan Roese wrote:
> > On 12/23/21 08:26, Tony Dinh wrote:
> > > Add include configs file for Pogoplug V4 board
> > >
> > > Signed-off-by: Tony Dinh <mibodhi at gmail.com>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > >   include/configs/pogo_v4.h | 94 +++++++++++++++++++++++++++++++++++++++
> > >   1 file changed, 94 insertions(+)
> > >   create mode 100644 include/configs/pogo_v4.h
> > >
> > > diff --git a/include/configs/pogo_v4.h b/include/configs/pogo_v4.h
> > > new file mode 100644
> > > index 0000000000..b449986e8c
> > > --- /dev/null
> > > +++ b/include/configs/pogo_v4.h
> > > @@ -0,0 +1,94 @@
> > > +/* SPDX-License-Identifier: GPL-2.0+ */
> > > +/*
> > > + * Copyright (C) 2014-2021 Tony Dinh <mibodhi at gmail.com>
> > > + *
> > > + * Based on
> > > + * Copyright (C) 2012
> > > + * David Purdy <david.c.purdy at gmail.com>
> > > + *
> > > + * Based on Kirkwood support:
> > > + * (C) Copyright 2009
> > > + * Marvell Semiconductor <www.marvell.com>
> > > + * Written-by: Prafulla Wadaskar <prafulla at marvell.com>
> > > + */
> > > +
> > > +#ifndef _CONFIG_POGO_V4_H
> > > +#define _CONFIG_POGO_V4_H
> > > +
> > > +/*
> > > + * Machine type definition and ID
> > > + */
> > > +#define MACH_TYPE_POGO_V4          3960
> > > +#define CONFIG_MACH_TYPE           MACH_TYPE_POGO_V4
> >
> > Are you really using the pretty old CONFIG_MACH_TYPE to boot Linux
> > on this device?
> >
> > > +
> > > +/*
> > > + * High Level Configuration Options (easy to change)
> > > + */
> > > +#define CONFIG_FEROCEON_88FR131            /* #define CPU Core subversion */
> > > +#define CONFIG_KW88F6192           /* SOC Name */
> >
> > At least CONFIG_FEROCEON_88FR131 is available in Kconfig
> > (arch/arm/mach-kirkwood/Kconfig), so there should be no need to add it
> > via some header.
> >
> > Please double-check other macros in this header as well for availability
> > in Kconfig.
>
> At this point you can now make CI do this for you as we have a test that
> will fail if there's unmigrated symbols in your board header file.  The
> logic can also be copy/pasted out to a script to run by yourself too.

I have not used CI before (not sure how). But I used a script copied
from your post:

https://lists.denx.de/pipermail/u-boot/2021-September/460085.html

./check-migrated-symbols.sh include/configs/pogo_v4.h

That should be enough to see which ones to migrate, right?

Thanks,
Tony

> --
> Tom