[RFC] nvme: Split out PCI support

Mark Kettenis mark.kettenis at xs4all.nl
Sun Jan 16 18:15:31 CET 2022


> Date: Tue, 11 Jan 2022 11:16:54 -0500
> From: Tom Rini <trini at konsulko.com>
> 
> On Fri, Dec 31, 2021 at 09:00:20PM +0100, Mark Kettenis wrote:
> 
> > Apple SoCs have an integrated NVMe controller that isn't connected
> > over a PCIe bus. In preparation for adding support for this NVMe
> > controller, split out the PCI support into its own file. This file
> > is selected through a new CONFIG_NVME_PCI Kconfig option, so do
> > a wholesale replacement of CONFIG_NVME with CONFIG_NVME_PCI.
> > 
> > Signed-off-by: Mark Kettenis <kettenis at openbsd.org>
> > ---
> > 
> > I only did the s/CONFIG_NVME/CONFIG_NVME_PCI/ change for
> > firefly-rk3399_defconfig for now. If folks agree this is a reasonable
> > approach I'll do the wholesale replacement mentioned in the commit
> > message and integrate this in a series that actually adds support for
> > the Apple SoC NVMe controller.
> 
> This seems a reasonable approach.

Thanks Tom!

I sent a full series for adding NVMe support for the Apple Silicon
Macs on friday.  And I just sent a small follow-up series to support
the laptop keyboards.  Together with the power domain support series
that has already been reviewed, that pretty much gives us enough
support for all the machines that Apple released with the original M1
SoC.  It would be great if we could ship 2022.04 with that included.

There is a bit more to do afterwards.  PCI support, needed for the
type-A USB ports on the Mac mini, needs a bit more work still.  But
the type-C ports do work, so this shouldn't be a show-stopper for most
people.  Support for te newer laptops with M1 Pro/Max SoCs also needs
a bit more work still.

Thanks,

Mark


More information about the U-Boot mailing list