[PATCH 00/13] Add support for the Purism Librem5 Phone

Tom Rini trini at konsulko.com
Mon Jan 17 18:49:51 CET 2022


On Mon, Jan 17, 2022 at 09:14:05AM -0800, Angus Ainslie wrote:
> Hi Toni
> 
> On 2022-01-17 08:59, Tom Rini wrote:
> > On Mon, Jan 17, 2022 at 07:07:22AM -0800, Angus Ainslie wrote:
> > 
> > > I sent this patchset as a single monolithic patch and did not see any
> > > comment on it.
> > > 
> > > https://lists.denx.de/pipermail/u-boot/2022-January/471087.html
> > > 
> > > Here it is as a set of patches instead.
> > > 
> > > This is all of the code required to boot the Librem5 Phone.
> > > 
> > > It can boot the phone in uuu mode or directly from the eMMC
> > 
> > Yes, sorry, we're a little behind on imx-related patches right now.  In
> > general yes, splitting this up a bit helps, but it's too split now.
> > I'll reply with some specific questions / comments, but the way it was
> > before is better really.
> 
> Thanks for the review and I'll start making changes for v2.
> 
> About how it should be split up. Should all of the "board/purism/librem5"
> and config files be in one patch with the devicetree and documentation in
> separate patches ?

Since you've already split out driver/etc changes to other patches, one
patch with board/ and include/configs/ and configs/ and dts files is
fine.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220117/5a841a51/attachment.sig>


More information about the U-Boot mailing list