[PATCH v3] drivers: spi-nor: Add JEDEC id for W25Q16JV

[Tudor.Ambarus at microchip.com]

On 1/21/22 12:52 AM, Dhananjay Phadke wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On 1/20/2022 7:46 AM, Tudor.Ambarus at microchip.com wrote:
>>>>> FWIW, "w25q15jvm" would be the "correct" name in linux. Although for this
>>>>> particular flash the name in linux is "w25q16jv-im/jm"..
>>>>
>>>> would you fix it? :D
>>>>
>>>>>
>>>>> Anyhow, see [1] for a lengthy discussion on that name. That being said, I
>>>>> still don't share Tudors opinion on using that made up name, just because
>>>>> no one will find any flash if one searches for w25q16jvm in the internet.
>>>>
>>>> The temperature range "I/J" is skipped in the name because it does not have
>>>> any influence on the jedec-id. That's why we don't include the "Package Type"
>>>> field in the naming convention as well.
>>>
>>> Okay, I'm merging v3. let me know if you have any questions?
>>>
>>
>> For now it should be fine. But if anyone is feeling brave enough maybe we should
>> fix the naming scheme for winbond once and for all. It seems that the flashes
>> were we append "m" support DTR, and in fact winbond names them blabla-dtr [1].
>> So instead of "w25q16jvm" maybe it's better to convert to "w25q16jv-dtr".
>> Are there any volunteers to check if my assumption is correct?
>>
>> [1] https://www.winbond.com/hq/product/code-storage-flash-memory/serial-nor-flash/?__locale=en&selected=128Mb#Density
> 
> I would be happy to do it if there's consensus that we can break
> downstream device-tree users that hold older compatible string :-).

aren't these flashes using the generic jedec,spi-nor compatible?

> 
> I thought of w25q512jv-dtr for my patch [1] but saw "m" suffix used for
> other dtr parts.
> 
> On related note, that array can be sorted by Device ID.

better to order them alphabetically, not by jedec ID.

> 
> [1]
> https://lore.kernel.org/u-boot/0c3e4727-0997-a4c5-dab1-b09ea8781c72@linux.microsoft.com/
> 
> Dhananjay
>