[PATCH v2] tools: mkimage: Call verify_header after writing image to disk

Pali Rohár pali at kernel.org
Sat Jan 22 02:44:22 CET 2022


On Friday 21 January 2022 16:21:33 Tom Rini wrote:
> On Fri, Jan 14, 2022 at 06:34:43PM +0100, Pali Rohár wrote:
> 
> > If image backend provides verify_header callback then call it after writing
> > image to disk. This ensures that written image is correct.
> > 
> > Signed-off-by: Pali Rohár <pali at kernel.org>
> > Reviewed-by: Stefan Roese <sr at denx.de>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> > ---
> >  tools/mkimage.c | 41 +++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 41 insertions(+)
> 
> This breaks a number of platforms such as ls1021atwr_sdcard_qspi and
> it's not clear to me why exactly.

Maybe they were already broken and this patch just detected it?
Or verify_header callback for particular image type is reject valid
image?

Do you have some pointers to failed build logs?


More information about the U-Boot mailing list