[PATCH V2] phy: nop-phy: Enable reset-gpios support

Adam Ford aford173 at gmail.com
Sat Jan 22 18:47:26 CET 2022


On Fri, Jan 21, 2022 at 3:18 PM Tom Rini <trini at konsulko.com> wrote:
>
> On Mon, Jan 17, 2022 at 05:45:59PM -0600, Adam Ford wrote:
>
> > Some usb-nop-xceiv devices use a gpio to put them in and
> > out of reset.  Add a reset function to put them into that
> > state.  This is similar to how Linux handles the
> > usb-nop-xceiv driver.
> >
> > Signed-off-by: Adam Ford <aford173 at gmail.com>
> > ---
> > V2:  Only use the GPIO functions when DM_GPIO is enabled
> >      Add error handling so if the GPIO fails, it will shutdown
> >      the clocks and return with the error code.
> >      Call nop_phy_reset() instead of repeating the same code.
>
> drivers/phy/nop-phy.c:47:23: error: implicit declaration of function
> 'nop_phy_reset'; did you mean 'nop_phy_init'?
> [-Werror=implicit-function-declaration]
> is what I get now on those platforms.

I apparently forgot to encapsulate the nop_phy_ops reference to the
new function in an if-def.  I'll send a V3 shortly.

adam
>
> --
> Tom


More information about the U-Boot mailing list