[PATCH v1 3/5] scripts: Makefile.autoconf: allow CONFIG_SYS_CONFIG_NAME file to live in board directory

Simon Glass sjg at chromium.org
Mon Jan 31 00:14:33 CET 2022


Hi Troy,

On Thu, 6 Jan 2022 at 14:09, Troy Kisky <troy.kisky at boundarydevices.com> wrote:
>
> On 12/28/2021 12:33 AM, Simon Glass wrote:
> > Hi Troy,
> >
> > On Fri, 17 Dec 2021 at 16:02, Troy Kisky <troy.kisky at boundarydevices.com> wrote:
> >>
> >> Let the board specific include file live in the board directory.
> >>
> >> Signed-off-by: Troy Kisky <troy.kisky at boundarydevices.com>
> >> ---
> >>  scripts/Makefile.autoconf | 9 +++++++--
> >>  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > We are actually working on deleting these. What is the benefit of
> > putting it here?
> >
>
>
> Do you have an estimate on how long until the 1st one can be deleted?

If you look at sandbox.h it is fairly close, but still perhaps a
release or two away.

I'm not all that keen on adding the board directory as an include
directory, although I suppose it is OK. We need a way to know which
files are config.h headers so things like moveconfig can update them
easily and we can implement things like this:

https://patchwork.ozlabs.org/project/uboot/patch/20210918182122.1854781-1-sjg@chromium.org/

>
> The main benefit that I see is making it easier to clone or compare boards.
> You just duplicate/diff everything in the board directory and rename files to taste.

Yes I see that. Was that mentioned in the cover letter? I might have
missed it sorry.

>
> My goal for this series is NOT to force everyone to update their board, but rather to allow new
> boards to have all their board specific files in one directory.

OK.

Regards,
Simon


More information about the U-Boot mailing list