[PATCH 5/5] cmd/dfu: Enable 'dfu list' command without DFU_OVER_USB

Masami Hiramatsu masami.hiramatsu at linaro.org
Mon Jan 31 01:05:52 CET 2022


Hi Tom,

Thanks for testing, I confirmed the error.

  CC      cmd/dfu.o
cmd/dfu.c: In function ‘do_dfu’:
cmd/dfu.c:53:30: error: ‘interface’ undeclared (first use in this
function); did you mean ‘usb_interface’?
   53 |  ret = dfu_init_env_entities(interface, devstring);
      |                              ^~~~~~~~~
      |                              usb_interface
cmd/dfu.c:53:30: note: each undeclared identifier is reported only
once for each function it appears in
cmd/dfu.c:53:41: error: ‘devstring’ undeclared (first use in this
function); did you mean ‘fdt_string’?
   53 |  ret = dfu_init_env_entities(interface, devstring);
      |                                         ^~~~~~~~~
      |                                         fdt_string

Let me fix it.

Thank you!

2022年1月29日(土) 1:30 Tom Rini <trini at konsulko.com>:
>
> On Mon, Dec 06, 2021 at 02:45:11PM +0900, Masami Hiramatsu wrote:
>
> > Since dfu is not only used for USB, and some platform only
> > supports DFU_OVER_TFTP or EFI capsule update, dfu_alt_info
> > is defined on such platforms too.
> >
> > For such platform, 'dfu list' command is useful to check
> > how the current dfu_alt_info setting is parsed.
> >
> > Signed-off-by: Masami Hiramatsu <masami.hiramatsu at linaro.org>
>
> This patch breaks at least smegw01 and likely warp and iot2050 as well,
> please update the series and repost, thanks!
>
> --
> Tom



-- 
Masami Hiramatsu


More information about the U-Boot mailing list