[PATCH v2 1/2] Makefile: Create a file to indicate the config

Tom Rini trini at konsulko.com
Mon Jan 31 17:21:38 CET 2022


On Mon, Jan 31, 2022 at 09:13:07AM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, 31 Jan 2022 at 07:24, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Sun, Jan 30, 2022 at 08:52:24AM -0700, Simon Glass wrote:
> >
> > > At present it is not actually possible to discover the defconfig file that
> > > was used to build U-Boot, so far as I can tell. Write this out to a file
> > > in the build directory, so this is visible.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> >
> > I don't think we need this really normally, it's just for the follow-up
> > patch.
> 
> I'd argue that it is helpful to have this somewhere. Is there anywhere
> else in the build directory where it can be discovered?

It's not a guarantee to exist is my first problem.  My minor problems
are this needs to be in .gitignore and also I think this wasn't ensuring
output directory not source directory.  But I don't see the use case
this is filling.  If you're in-tree, you should know what you configured
and are working on.  If you're out of tree and didn't do any sort of
naming convention to your objdirs, did you also really care what
defconfig exactly (I use a mix of named and garbage-named temp dirs)?
And if you're a tool of some sort, you were told what to use at some
point I would assume.  Which all gets back to I don't see the use case
exactly for it.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220131/5466df72/attachment.sig>


More information about the U-Boot mailing list