[PATCH] tools/imx8mimage: Remove the usage of IVT reserved1 field

Michael Nazzareno Trimarchi michael at amarulasolutions.com
Sun Jul 3 08:43:33 CEST 2022


Hi Peng

On Sun, Jul 3, 2022 at 1:15 AM Peng Fan (OSS) <peng.fan at oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan at nxp.com>
>
> Commit log from NXP imx-mkimage:
> On iMX8MQ B2, ROM will check IVT header and requires the reserved fields
> in IVT to be 0.
> However, in imx-mkimage we set the reserved1 field for the offset from
> second boot image to SPL boot image, which was used for mfgtool but
> has deprecated. So remove it to fix the boot failure on iMX8MQ B2.
>
> Update imx8mimage to address same issue
>
> Cc: Mihai Chelalau <mihai.chelalau at nxp.com>
> Cc: Dan Douglass <dan.douglass at nxp.com>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> ---
>  tools/imx8mimage.c | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/tools/imx8mimage.c b/tools/imx8mimage.c
> index 4eed683396f..52baf4c9903 100644
> --- a/tools/imx8mimage.c
> +++ b/tools/imx8mimage.c
> @@ -505,14 +505,6 @@ void build_image(int ofd)
>                         exit(EXIT_FAILURE);
>                 } else {
>                         sld_header_off = sld_src_off - rom_image_offset;
> -                       /*
> -                        * Record the second bootloader relative offset in
> -                        * image's IVT reserved1
> -                        */
> -                       if (rom_version == ROM_V1) {
> -                               imx_header[IMAGE_IVT_ID].fhdr.reserved1 =
> -                                       sld_header_off - header_image_off;
> -                       }
>                         sld_fd = open(sld_img, O_RDONLY | O_BINARY);
>                         if (sld_fd < 0) {
>                                 fprintf(stderr, "%s: Can't open: %s\n",
> --
> 2.36.0
>

I have seen a similar change from Marek last week

tools: imx8mimage: Keep IVT reserved1 field zero always

Michael


More information about the U-Boot mailing list