[v4 04/12] configs: aspeed: Enable SPI flash features

[Chin-Ting Kuo]

Hi Cédric,

> -----Original Message-----
> From: Cédric Le Goater <clg at kaod.org>
> Sent: Friday, July 1, 2022 7:51 PM
> Subject: Re: [v4 04/12] configs: aspeed: Enable SPI flash features
> 
> On 7/1/22 11:28, Cédric Le Goater wrote:
> > On 5/24/22 07:56, Chin-Ting Kuo wrote:
> >> - Enable ASPEED SPI controller driver.
> >> - Enable SPI flash memory configurations.
> >> - Enable configurations for SPI flash manufacturers
> >>    supported on both ASPEED AST2500 and AST2600 AVL.
> >>
> >> Signed-off-by: Chin-Ting Kuo <chin-ting_kuo at aspeedtech.com>
> >> ---
> >>   configs/evb-ast2500_defconfig | 13 +++++++++++++
> >>   configs/evb-ast2600_defconfig | 13 +++++++++++++
> >>   2 files changed, 26 insertions(+)
> >>
> >> diff --git a/configs/evb-ast2500_defconfig
> >> b/configs/evb-ast2500_defconfig index 2371cc2742..fd04fe5a60 100644
> >> --- a/configs/evb-ast2500_defconfig
> >> +++ b/configs/evb-ast2500_defconfig
> >> @@ -35,6 +35,16 @@ CONFIG_DM_I2C=y
> >>   CONFIG_SYS_I2C_ASPEED=y
> >>   CONFIG_MMC_SDHCI=y
> >>   CONFIG_MMC_SDHCI_ASPEED=y
> >> +CONFIG_DM_SPI_FLASH=y
> >> +CONFIG_SPI_FLASH_SFDP_SUPPORT=y
> >> +CONFIG_SPI_FLASH_GIGADEVICE=y
> >> +CONFIG_SPI_FLASH_ISSI=y
> >> +CONFIG_SPI_FLASH_MACRONIX=y
> >> +CONFIG_SPI_FLASH_SPANSION=y
> >> +CONFIG_SPI_FLASH_STMICRO=y
> >> +CONFIG_SPI_FLASH_SST=y
> >> +CONFIG_SPI_FLASH_WINBOND=y
> >> +# CONFIG_SPI_FLASH_USE_4K_SECTORS is not set
> >>   CONFIG_PHY_REALTEK=y
> >>   CONFIG_DM_ETH=y
> >>   CONFIG_FTGMAC100=y
> >> @@ -44,6 +54,9 @@ CONFIG_RAM=y
> >>   CONFIG_DM_RESET=y
> >>   CONFIG_DM_SERIAL=y
> >>   CONFIG_SYS_NS16550=y
> >> +CONFIG_SPI=y
> >> +CONFIG_DM_SPI=y
> >> +CONFIG_SPI_ASPEED=y
> >>   CONFIG_SYSRESET=y
> >>   CONFIG_TIMER=y
> >>   CONFIG_WDT=y
> >
> > This is breaking boot on the AST2500 evb (QEMU) . I haven't found why
> > yet. You might want to take a look.
> 
> The resulting binary is too big for the flash layout we use on OpenBMC.

What’s the flash layout used by you? I tested this patch series on AST2500 EVB, and it was okay before.


Chin-Ting

> 
> C.