[PATCH 1/8] arm64: dts: sdm845: Remove redundant u-boot DT properties

Daniel Thompson daniel.thompson at linaro.org
Mon Jul 4 17:58:42 CEST 2022


On Mon, Jul 04, 2022 at 06:28:38PM +0530, Sumit Garg wrote:
> U-boot specific DT properties belong to *-uboot.dtsi

... and are already included in starqltechn-uboot.dtsi (which is the
only current consumer of sdm845.dtsi).


Adding fuller comments, such as the above, makes things much easier to
review: it makes clear why you consider the properties redundant rather
then misfiled.


Daniel.


> , so remove
> corresponding redundant properties.
> 
> Signed-off-by: Sumit Garg <sumit.garg at linaro.org>
> ---
>  arch/arm/dts/sdm845.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/dts/sdm845.dtsi b/arch/arm/dts/sdm845.dtsi
> index 6f2fb20d68..88030156d9 100644
> --- a/arch/arm/dts/sdm845.dtsi
> +++ b/arch/arm/dts/sdm845.dtsi
> @@ -18,7 +18,6 @@
>  		compatible = "simple-bus";
>  
>  		gcc: clock-controller at 100000 {
> -			u-boot,dm-pre-reloc;
>  			compatible = "qcom,gcc-sdm845";
>  			reg = <0x100000 0x1f0000>;
>  			#clock-cells = <1>;
> @@ -27,7 +26,6 @@
>  		};
>  
>  		gpio_north: gpio_north at 3900000 {
> -			u-boot,dm-pre-reloc;
>  			#gpio-cells = <2>;
>  			compatible = "qcom,sdm845-pinctrl";
>  			reg = <0x3900000 0x400000>;
> @@ -38,7 +36,6 @@
>  		};
>  
>  		tlmm_north: pinctrl_north at 3900000 {
> -			u-boot,dm-pre-reloc;
>  			compatible = "qcom,tlmm-sdm845";
>  			reg = <0x3900000 0x400000>;
>  			gpio-count = <150>;
> -- 
> 2.25.1
> 


More information about the U-Boot mailing list