[PATCH 4/8] board: qualcomm: Add support for dragonboard845c

[Sumit Garg]

Hi Daniel,

On Mon, 4 Jul 2022 at 21:36, Daniel Thompson <daniel.thompson at linaro.org> wrote:
>
> On Mon, Jul 04, 2022 at 06:28:41PM +0530, Sumit Garg wrote:
> > diff --git a/arch/arm/dts/dragonboard845c-uboot.dtsi b/arch/arm/dts/dragonboard845c-uboot.dtsi
> > new file mode 100644
> > index 0000000000..8b5a7ee573
> > --- /dev/null
> > +++ b/arch/arm/dts/dragonboard845c-uboot.dtsi
> > @@ -0,0 +1,37 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> > +/*
> > + * U-Boot addition to handle Qualcomm Robotics RB3 Development Platform
> > + * (dragonboard845c) pins
> > + *
> > + * (C) Copyright 2022 Sumit Garg <sumit.garg at linaro.org>
> > + */
> > +
> > +/
> > +{
> > +     soc {
> > +             u-boot,dm-pre-reloc;
> > +
> > +             serial at a84000 {
> > +                     u-boot,dm-pre-reloc;
> > +             };
> > +
> > +             clock-controller at 100000 {
> > +                     u-boot,dm-pre-reloc;
> > +             };
> > +
> > +             pinctrl_north at 3900000 {
> > +                     u-boot,dm-pre-reloc;
> > +             };
> > +     };
> > +};
>
> These additional u-boot,dm-pre-reloc changes are different to the ones
> that appear in starqltechn-uboot.dtsi .

As I mentioned in the patch #1 review, u-boot properties are specified
incorrectly in starqltechn-uboot.dtsi. I will correct that.

> That suggests that either patch 1
> is not actually removing redundant properties or that the DB845C port is
> wrong.

The other node I left for DB845C without "u-boot,dm-pre-reloc" is
"gpio_north at 3900000" as currently I am not using GPIO driver prior to
relocation.

>-Sumit
>
> > +config TARGET_DRAGONBOARD845C
> > +     bool "96Boards Dragonboard 845C"
> > +     help
> > +       Support for 96Boards Dragonboard 845C aka Robotics RB3 Development
> > +       Platform. This board complies with 96Board Open Platform
>
> Nitpicking but... s/96Board/96Boards/
>

Okay, I will correct it.

-Sumit

>
> Daniel.