[PATCH v2 3/6] patman: Don't look at sys.argv when parsing settings

Simon Glass sjg at chromium.org
Tue Jul 5 11:59:07 CEST 2022


On Fri, 1 Jul 2022 at 14:24, Douglas Anderson <dianders at chromium.org> wrote:
>
> If you call the parser and tell it to parse but don't pass arguments
> in then it will default to looking at sys.argv. This isn't really what
> was intended and seems to have some side effects. Let's not do it.
>
> NOTE: to see some of the side effects, note that this patch breaks
> "patman -c1" if you don't have the patch ("patman: Fix implicit
> command inserting") before it.
>
> Signed-off-by: Douglas Anderson <dianders at chromium.org>
> Tested-by: Brian Norris <briannorris at chromium.org>
> Reviewed-by: Brian Norris <briannorris at chromium.org>
> ---
>
> (no changes since v1)
>
>  tools/patman/settings.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list