[PATCH 6/9] dm: core: Support accessing core tags

Tom Rini trini at konsulko.com
Tue Jul 5 14:39:36 CEST 2022


On Tue, Jun 28, 2022 at 11:18:51PM +0900, AKASHI Takahiro wrote:
> On Tue, Jun 28, 2022 at 09:37:56AM -0400, Simon Glass wrote:
> > Hi Simon,
> > 
> > On Sun, May 08, 2022 at 04:39:24AM -0600, Simon Glass wrote:
> > > At present tag numbers are only allocated for non-core data, meaning that
> > > the 'core' data, like priv and plat, are accessed through dedicated
> > > functions.
> > >
> > > For debugging and consistency it is convenient to use tags for this 'core'
> > > data too. Add support for this, with new tag numbers and functions to
> > > access the pointer and size for each.
> > >
> > > Update one of the test drivers so that the uclass-private data can be
> > > tested here.
> > >
> > > There is some code duplication with functions like device_alloc_priv() but
> > > this is not addressed for now. At some point, some rationalisation may
> > > help to reduce code size, but more thought it needed on that.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > >  drivers/core/device.c   | 65 +++++++++++++++++++++++++++++++++
> > >  drivers/misc/test_drv.c |  4 ++-
> > >  include/dm/device.h     | 25 +++++++++++++
> > >  include/dm/tag.h        | 13 ++++++-
> > >  test/dm/core.c          | 80 +++++++++++++++++++++++++++++++++++++++++
> > >  tools/dtoc/test_dtoc.py |  4 +++
> > >  6 files changed, 189 insertions(+), 2 deletions(-)
> > >
> > Applied to u-boot-dm, thanks!
> 
> I expect you to reply to my comments:
> https://lists.denx.de/pipermail/u-boot/2022-May/483606.html

Simon?  This is why I haven't applied the PR for -next yet, I was
waiting for your comments here, thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220705/fb0a398a/attachment.sig>


More information about the U-Boot mailing list