[RFC PATCH 1/2] efi_loader: Add SPI I/O protocol support

[Paul Barker]

On 11/07/2022 14:12, Ilias Apalodimas wrote:
> Hi Paul
> 
>> +static efi_status_t
>> +efi_spi_bus_clock(const struct efi_spi_peripheral *spi_peripheral,
>> +                 u32 *clock_hz)
>> +{
>> +       EFI_ENTRY("%p, %p", spi_peripheral, clock_hz);
>> +       return EFI_EXIT(EFI_UNSUPPORTED);
>> +}
>> +
> 
> All the EFI_ENTRY/EXIT calls should be on functions marked as EFIAPI.
> Most of the functions you use it on seem to be static function that
> will never be called by an EFI application.

These functions are actually exported as part of EFI protocols and so 
can be called by an EFI application. So I should mark them as EFIAPI 
when I send v2 of this series.

Thanks,

-- 
Paul Barker
Principal Software Engineer
SanCloud Ltd

e: paul.barker at sancloud.com
w: https://sancloud.com/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xA67255DFCCE62ECD.asc
Type: application/pgp-keys
Size: 7526 bytes
Desc: OpenPGP public key
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220711/af627e70/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 236 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220711/af627e70/attachment.sig>