[PATCH 2/5] firmware: zynqmp: Load config overlay for core0 to pmufw

Michal Simek michal.simek at amd.com
Fri Jul 15 18:34:54 CEST 2022



On 7/15/22 18:13, Stefan Herbrechtsmeier wrote:
> Am 15.07.2022 um 11:39 schrieb Ashok Reddy Soma:
>> Try loading pmufw config overlay for core0, if it doesn't return any
>> error it means pmufw is accepting nodes for other IP's. Otherwise dont
>> try to load config object for any other IP, just return from
>> zynqmp_pmufw_node function.
>>
>> Signed-off-by: Ashok Reddy Soma <ashok.reddy.soma at xilinx.com>
>> ---
>>
>>   drivers/firmware/firmware-zynqmp.c | 14 ++++++++++++++
>>   1 file changed, 14 insertions(+)
>>
>> diff --git a/drivers/firmware/firmware-zynqmp.c 
>> b/drivers/firmware/firmware-zynqmp.c
>> index 34d9b47003..288151533e 100644
>> --- a/drivers/firmware/firmware-zynqmp.c
>> +++ b/drivers/firmware/firmware-zynqmp.c
>> @@ -68,8 +68,13 @@ int zynqmp_pmufw_config_close(void)
>>       return 0;
>>   }
>> +static bool config_enabled;
>> +
> 
> Please move the variable inside the function.

How can this work? When you move it to zynqmp_pmufw_node() then won't be visible 
in zynqmp_power_probe() and vice-versa.

M


More information about the U-Boot mailing list