[PATCH] spl: Move check for SPL_LIBCOMMON support to header

Andrew Davis afd at ti.com
Sun Jul 17 17:00:28 CEST 2022


On 7/16/22 7:00 AM, Simon Glass wrote:
> Hi Andrew,
> 
> On Fri, 15 Jul 2022 at 09:35, Andrew Davis <afd at ti.com> wrote:
>>
>> From: "Andrew F. Davis" <afd at ti.com>
>>
>> Print statements in SPL depend on lib/common support, due to this many
>> such print statements are ifdef'd. Instead of checking at each call site
>> move the check to the common.h header and remove these inline checks.
> 
> nit: stdio.h I think?
> 

Ah yes, looks like this header got renamed since I wrote this patch. Will
fix if v2 is needed.

Thanks,
Andrew

>>
>> Signed-off-by: Andrew F. Davis <afd at ti.com>
>> Reviewed-by: Simon Glass <sjg at chromium.org>
>> ---
>>   boot/common_fit.c        |  2 --
>>   common/spl/spl.c         |  4 +---
>>   common/spl/spl_ext.c     |  8 --------
>>   common/spl/spl_fat.c     |  6 ------
>>   common/spl/spl_mmc.c     | 18 ------------------
>>   common/spl/spl_usb.c     |  2 --
>>   drivers/mmc/mmc-uclass.c |  2 --
>>   drivers/mmc/mmc.c        | 12 ------------
>>   drivers/mmc/mmc_legacy.c |  2 --
>>   include/stdio.h          |  5 ++---
>>   10 files changed, 3 insertions(+), 58 deletions(-)
>>
> 
> Regards,
> Simon


More information about the U-Boot mailing list