[PATCH v2 5/5] rockchip: rock-pi-4: dts: spi: Make the index of the spi flash the same in SPL and U-Boot proper

Quentin Schulz quentin.schulz at theobroma-systems.com
Mon Jul 18 10:33:18 CEST 2022

Hi Xavier,

On 7/15/22 18:30, Xavier Drudis Ferran wrote:
> Spi0 is not needed in SPL and SPL could be a little smaller without it,
> but then the SF_DEFAULT_BOOT would have to be 0 to refer to spi1, and
> that's confusing, because once U-Boot proper runs, it numbers the bus 1.
> Add spi0 to the pre-reloc and spl trees so that the flash is always
> connected to bus 1.

Mmmm... Could we instead make U-Boot use the bus number from the alias 
in the aliases DT node? I think the mmc subsystem does this already and 
it would mean we don't need to enable unnecessary devices. Also, relying 
on boot order for the bus number is brittle in Linux, I don't know about 
U-Boot, but if we can avoid this assumption, it'd be great :)

for how to do it today?

> Changes since v1:
>     - new patch in v2.

Your patch series got sent with each commit in their individual thread 
instead of the usual way, with 1/X patch as the first mail in the 
thread. I think this could make this difficult to merge for the 
maintainer, could you please try to put all your patch into a single 
thread for the next version/patch series you will send? `git send-email 
*.patch` should do that for you by default I'm pretty sure.

What happened with your patches:

What should have had happened:


More information about the U-Boot mailing list