[PATCH] efi: test/py: repair authenticated capsules tests

[Heinrich Schuchardt]

On 6/28/22 07:14, AKASHI Takahiro wrote:
> Heinrich,
>
> On Mon, Jun 27, 2022 at 12:46:07PM +0200, Heinrich Schuchardt wrote:
>> On 6/27/22 12:23, Vincent Stehlé wrote:
>>> The UEFI console initialisation has been modified by commit 68edbed454b8
>>> ("efi_loader: initialize console size late"). A corresponding workaround is
>>> now necessary for the automated tests, as added to some of the tests
>>> already by commit e05bd68ed5fc ("test: work around for EFI terminal size
>>> probing").
>>>
>>> Add the same workaround to the UEFI authenticated capsules tests to repair
>>> them.
>>>
>>> This can be tested with sandbox_defconfig, sandbox64_defconfig or
>>> sandbox_flattree_defconfig, plus CONFIG_EFI_CAPSULE_AUTHENTICATE=y.
>>>
>>> Signed-off-by: Vincent Stehlé <vincent.stehle at arm.com>
>>
>> Why are these tests not run in Gitlab?
>> Can't we permanently adjust one of said defconfigs for this purpose?
>> Or do we need a new defconfig for testing?
>
> Because we cannot turn on or off capsule authentication dynamically
> on a single U-Boot image, we cannot test non-signed test cases
> and signed test cases simultaneously in CI.
>
> That is why I proposed a new config file for sandbox with
> EFI_CAPSULE_AUTHENTICATE, but the idea was rejected (if I remember correctly, by Simon).
>
> That said, I also made a small change to unsigned test cases
> (test_efi_capsule_firmware(_*).py) so that they can *pass* even with
> EFI_CAPSULE_AUTHENTICATE enabled.
> (As you can image, however, actual capsule update never happens in
> this test environment.)
>
> commit e012550cd7d6 ("test/py: efi_capsule: check the results in case of
> CAPSULE_AUTHENTICATE")
>
>
> -Takahiro Akashi

Reviewed-by: Heinrich Schuchardt <xypron.glpk at gmx.de>