[PATCH 1/1] usb: storage: stop probe on "Invalid device"

Janne Grunau j at jannau.net
Thu Jul 21 19:29:35 CEST 2022


Fixes a crash during probing of sd card readers without medium present.

Link: https://github.com/AsahiLinux/linux/issues/44
Signed-off-by: Janne Grunau <j at jannau.net>
---
 common/usb_storage.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/common/usb_storage.c b/common/usb_storage.c
index eaa31374ef73..5a62d61f4382 100644
--- a/common/usb_storage.c
+++ b/common/usb_storage.c
@@ -236,9 +236,7 @@ static int usb_stor_probe_device(struct usb_device *udev)
 			debug("%s: Found device %p\n", __func__, udev);
 		} else {
 			debug("usb_stor_get_info: Invalid device\n");
-			ret = device_unbind(dev);
-			if (ret)
-				return ret;
+			return device_unbind(dev);
 		}
 
 		ret = blk_probe_or_unbind(dev);
-- 
2.35.1



More information about the U-Boot mailing list