[PATCH 1/2] powerpc: mpc85xx: Add support for generating QorIQ pre-PBL eSDHC boot sector

[Pali Rohár]

On Thursday 14 July 2022 01:49:59 Pali Rohár wrote:
> On Tuesday 28 June 2022 20:07:48 Pali Rohár wrote:
> > On Thursday 23 June 2022 19:17:55 Pali Rohár wrote:
> > > On Saturday 04 June 2022 15:02:38 Pali Rohár wrote:
> > > > On Wednesday 18 May 2022 12:53:20 Pali Rohár wrote:
> > > > > On Wednesday 11 May 2022 22:59:28 Pali Rohár wrote:
> > > > > > On Monday 25 April 2022 14:36:14 Pali Rohár wrote:
> > > > > > > On Monday 25 April 2022 05:25:34 Priyanka Jain (OSS) wrote:
> > > > > > > > >-----Original Message-----
> > > > > > > > >From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Pali Rohár
> > > > > > > > >Sent: Tuesday, April 5, 2022 7:11 PM
> > > > > > > > >To: Priyanka Jain <priyanka.jain at nxp.com>; Qiang Zhao <qiang.zhao at nxp.com>;
> > > > > > > > >Shengzhou Liu <shengzhou.liu at nxp.com>; Alexander Graf <agraf at csgraf.de>;
> > > > > > > > >Bin Meng <bmeng.cn at gmail.com>; Wolfgang Denk <wd at denx.de>; Sinan
> > > > > > > > >Akman <sinan at writeme.com>
> > > > > > > > >Cc: u-boot at lists.denx.de
> > > > > > > > >Subject: [PATCH 1/2] powerpc: mpc85xx: Add support for generating QorIQ pre-
> > > > > > > > >PBL eSDHC boot sector
> > > > > > > > >
> > > > > > > > >QorIQ U-Boot binary for SD card booting compiled during build process (either u-
> > > > > > > > >boot.bin or u-boot-with-spl.bin) cannot be directly loaded by QorIQ pre-PBL
> > > > > > > > >BootROM. Compiled U-Boot binary first needs to be processed by Freescale
> > > > > > > > >boot_format tool as described in doc/README.mpc85xx-sd-spi-boot
> > > > > > > > >
> > > > > > > > >BootROM requires that image on SD card must contain special boot sector.
> > > > > > > > >Implement support for generating this special boot sector directly in U-Boot start
> > > > > > > > >code. Boot sector needs to be at the beginning of the image, so when compiling
> > > > > > > > >only proper U-Boot without SPL then it needs to be in proper U-Boot. When
> > > > > > > > >compiling SPL with proper U-Boot then it needs to be only in SPL.
> > > > > > > > >
> > > > > > > > >Support can be enabled by a new config option
> > > > > > > > >FSL_PREPBL_ESDHC_BOOT_SECTOR.
> > > > > > > > >Via other two additional options FSL_PREPBL_ESDHC_BOOT_SECTOR_START and
> > > > > > > > >FSL_PREPBL_ESDHC_BOOT_SECTOR_DATA it is possible to tune how final U-Boot
> > > > > > > > >image could be stored on the SD card.
> > > > > > > > >
> > > > > > > > >Signed-off-by: Pali Rohár <pali at kernel.org>
> > > > > > > > >---
> > > > > > > > 
> > > > > > > > Kindly rebase the series to master.
> > > > > > > > 
> > > > > > > > Regards
> > > > > > > > Priyanka
> > > > > > > 
> > > > > > > Hello! Both patches still applies cleanly on master, just they depend
> > > > > > > on another patch series (powerpc: mpc85xx: Fix and cleanup mpc85xx code)
> > > > > > > which I mentioned in cover letter and therefore needs V2 patch of
> > > > > > > "powerpc: mpc85xx: Set TEXT_BASE addresses to real base values" which I
> > > > > > > sent recently.
> > > > > > 
> > > > > > I sent a new version v2 of this patch, see email:
> > > > > > [PATCH v2] powerpc: mpc85xx: Add support for generating QorIQ pre-PBL eSDHC boot sector
> > > > > 
> > > > > Priyanka: PING
> > > > 
> > > > PING?
> > > 
> > > PING?
> > 
> > PING?
> > 
> > V2 now and still applies cleanly on top of next branch
> > https://patchwork.ozlabs.org/project/uboot/patch/20220511185731.3000-1-pali@kernel.org/
> 
> PING?

PING?

> > And why v2 has "Changes Requested" state in above patchwork?
> > 
> > I do not see any comment for v2 on mailing list nor on patchwork.
> > So what is requested from me?