[PATCH 2/3] i2c: i2c-cdns: Fix write transaction state
Michal Simek
michal.simek at xilinx.com
Tue Mar 1 09:16:51 CET 2022
From: Sai Pavan Boddu <sai.pavan.boddu at xilinx.com>
Start write transfer after loading data to FIFO.
Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu at xilinx.com>
Reviewed-by: Ashok Reddy Soma <ashok.reddy.soma at xilinx.com>
Signed-off-by: Michal Simek <michal.simek at xilinx.com>
---
drivers/i2c/i2c-cdns.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/i2c/i2c-cdns.c b/drivers/i2c/i2c-cdns.c
index 5736afb45191..07d53be11f12 100644
--- a/drivers/i2c/i2c-cdns.c
+++ b/drivers/i2c/i2c-cdns.c
@@ -251,6 +251,7 @@ static int cdns_i2c_write_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
u8 *cur_data = data;
struct cdns_i2c_regs *regs = i2c_bus->regs;
u32 ret;
+ bool start = 1;
/* Set the controller in Master transmit mode and clear FIFO */
setbits_le32(®s->control, CDNS_I2C_CONTROL_CLR_FIFO);
@@ -269,6 +270,11 @@ static int cdns_i2c_write_data(struct i2c_cdns_bus *i2c_bus, u32 addr, u8 *data,
while (len-- && !is_arbitration_lost(regs)) {
writel(*(cur_data++), ®s->data);
+ /* Trigger write only after loading data */
+ if (start) {
+ writel(addr, ®s->address);
+ start = 0;
+ }
if (len && readl(®s->transfer_size) == CDNS_I2C_FIFO_DEPTH) {
ret = cdns_i2c_wait(regs, CDNS_I2C_INTERRUPT_COMP |
CDNS_I2C_INTERRUPT_ARBLOST);
--
2.35.1
More information about the U-Boot
mailing list