[PATCH u-boot-marvell 7/8] arm: mvebu: turris_omnia: Signal error when sata/pcie DT mode

Pali Rohár pali at kernel.org
Wed Mar 2 12:47:57 CET 2022


Show error message when DT file does not contain sata or pcie node which
should be explicitly disabled. This can happen when U-Boot code for finding
those nodes is incomplete or when those DT nodes are in different
unexpected location. In any case it is needed to know if DT not was not
explicitly disabled as it could mean that combo slots where setup
incorrectly.

Signed-off-by: Pali Rohár <pali at kernel.org>
---
 board/CZ.NIC/turris_omnia/turris_omnia.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/board/CZ.NIC/turris_omnia/turris_omnia.c b/board/CZ.NIC/turris_omnia/turris_omnia.c
index 57b797db4a8e..e2f4daa827ed 100644
--- a/board/CZ.NIC/turris_omnia/turris_omnia.c
+++ b/board/CZ.NIC/turris_omnia/turris_omnia.c
@@ -531,8 +531,10 @@ static void disable_sata_node(void *blob)
 		else
 			debug("Disabled SATA DT node\n");
 
-		break;
+		return;
 	}
+
+	printf("Cannot find SATA DT node!\n");
 }
 
 static void disable_pcie_node(void *blob, int port)
@@ -560,6 +562,8 @@ static void disable_pcie_node(void *blob, int port)
 			return;
 		}
 	}
+
+	printf("Cannot find PCIe port %d DT node!\n", port);
 }
 
 static void fixup_msata_port_nodes(void *blob)
-- 
2.20.1



More information about the U-Boot mailing list