[PATCH v2 10/10] cmd: rng: Add support for selecting RNG device

[Simon Glass]

Hi Sughosh,

On Tue, 1 Mar 2022 at 21:56, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
>
> hi Simon,
>
> On Tue, 1 Mar 2022 at 20:29, Simon Glass <sjg at chromium.org> wrote:
> >
> > Hi Sughosh,
> >
> > On Mon, 28 Feb 2022 at 05:07, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
> > >
> > > The 'rng' u-boot command is used for printing a select number of
> > > random bytes on the console. Currently, the RNG device from which the
> > > random bytes are read is fixed. However, a platform can have multiple
> > > RNG devices, one example being qemu, which has a virtio RNG device and
> > > the RNG pseudo device through the TPM chip.
> > >
> > > Extend the 'rng' command so that the user can provide the RNG device
> > > number from which the random bytes are to be read. This will be the
> > > device index under the RNG uclass.
> > >
> > > Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> > > Tested-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > > ---
> > >
> > > Changes since V1:
> > > * Changed the help text to show order of the parameters passed
> > >   to the rng command, based on review comment from Heinrich
> > >
> > >  cmd/rng.c | 31 +++++++++++++++++++++++--------
> > >  1 file changed, 23 insertions(+), 8 deletions(-)
> >
> > Please add a test for the command and also add doc/usage
>
> We already have a test for the RNG uclass, which is basically doing
> the exact same thing. Do we still need one for the command? Or is it
> for testing the command parameters?

Yes and it provides test coverage. See acpi.c for an example test. It
can be quite simple I suspect.

Regards,
Simon