[PATCH] cmd: test: pinmux: Do not check all empty spaces

Patrice CHOTARD patrice.chotard at foss.st.com
Mon Mar 7 17:18:49 CET 2022


Hi Michal

On 3/7/22 16:48, Michal Simek wrote:
> There is really no value to check empty spaces. That's why use
> ut_assert_nextlinen() instead of ut_assert_nextline().
> This change ensures that PINMUX_SIZE can be increased without changing
> tests.
> 
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
> 
> https://lore.kernel.org/all/3a6be84c8354f38754a9838670cc0319e84f29e8.1645626183.git.michal.simek@xilinx.com/
> ---
>  test/cmd/pinmux.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/test/cmd/pinmux.c b/test/cmd/pinmux.c
> index 8ae807b53779..ba338b8dce85 100644
> --- a/test/cmd/pinmux.c
> +++ b/test/cmd/pinmux.c
> @@ -16,18 +16,18 @@ static int dm_test_cmd_pinmux_status_pinname(struct unit_test_state *uts)
>  	/* Test that 'pinmux status <pinname>' displays the selected pin. */
>  	console_record_reset();
>  	run_command("pinmux status a5", 0);
> -	ut_assert_nextline("a5        : gpio input .                            ");
> +	ut_assert_nextlinen("a5        : gpio input .");
>  	ut_assert_console_end();
>  
>  	console_record_reset();
>  	run_command("pinmux status P7", 0);
> -	ut_assert_nextline("P7        : GPIO2 bias-pull-down input-enable.      ");
> +	ut_assert_nextlinen("P7        : GPIO2 bias-pull-down input-enable.");
>  	ut_assert_console_end();
>  
>  	console_record_reset();
>  	run_command("pinmux status P9", 0);
> -	ut_assert_nextline("single-pinctrl pinctrl-single-no-width: missing register width");
> -	ut_assert_nextline("P9 not found");
> +	ut_assert_nextlinen("single-pinctrl pinctrl-single-no-width: missing register width");
> +	ut_assert_nextlinen("P9 not found");
>  	ut_assert_console_end();
>  
>  	return 0;

Reviewed-by: Patrice Chotard <patrice.chotard at foss.st.com>

Thanks
Patrice


More information about the U-Boot mailing list