[EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

[Stefano Babic]

Hi Tom,

On 08.03.22 13:48, Tom Rini wrote:
> On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
>> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain <gaurav.jain at nxp.com> wrote:
>>
>>> I further checked on your concern and propose the below change to stop building caam driver in SPL for imx6dl_mamoj.
>>>
>>> --- a/configs/imx6dl_mamoj_defconfig
>>> +++ b/configs/imx6dl_mamoj_defconfig
>>> @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
>>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0525
>>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
>>>   CONFIG_CI_UDC=y
>>> +CONFIG_SPL_CRYPTO=n
>>
>> No, this is not how defconfig works.
>>
>> You should set:
>>
>> # CONFIG_SPL_CRYPTO is not set
> 
> But more, WHY is this the right answer?  You're disabling functionality
> and the board maintainers aren't even on the CC list for this thread it
> looks like.

This was my blocking point, too, for this series. There is no answer 
about the board.

I can just imagine (as for other MX6DL) that the required functionality 
is secure boot, then CONFIG_IMX_HAB is enough. But well, just the board 
maintainers can say. Added Raffaele and Jagan as reported maintainers 
for this board.

>  Why are you not fixing the board so it still links?  What
> makes this board a problem that other (I assume) imx6dl boards are not? 

Well, this board has, compared to other MX6DL, a lot of SPL_ option that 
are bloating the SPL size. And then does not match anymore with the 
internal RAm, while other MX6DL boards are not so affected by the 
increased size because they have no SPL at all or SPL with less options 
and then smaller. We do not need to fix the link, but reduce the size, 
and nobody else than the maintainers can tell us if removing some 
feature is ok.

Regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================