[PATCH v1 1/9] arm: nuvoton: Add support for Nuvoton NPCM845 BMC

[Stanley Chu]

Hi Sean,
Thanks for the review.
It is addressed in the gpio driver patch as below.
https://patchwork.ozlabs.org/project/uboot/patch/20220225021450.18690-1-yschu@nuvoton.com/

--
Stanley

On Thu, Dec 16, 2021 at 6:30 AM Sean Anderson <seanga2 at gmail.com> wrote:
>
> On 12/15/21 5:16 PM, Jesse Taube wrote:
> >
> >
> > On 12/15/21 13:32, Sean Anderson wrote:
> >> On 12/14/21 9:57 PM, Stanley Chu wrote:
> >>> Add basic support for the Nuvoton NPCM845 BMC.
> >>>
> >>> Signed-off-by: Stanley Chu <yschu at nuvoton.com>
> >>> ---
> >>>    arch/arm/Kconfig                          |   9 +
> >>>    arch/arm/Makefile                         |   1 +
> >>>    arch/arm/include/asm/arch-npcm8xx/clock.h | 164 ++++++++++++
> >>>    arch/arm/include/asm/arch-npcm8xx/espi.h  |  23 ++
> >>>    arch/arm/include/asm/arch-npcm8xx/gcr.h   | 313 ++++++++++++++++++++++
> >>>    arch/arm/include/asm/arch-npcm8xx/gpio.h  |  11 +
> >>>    arch/arm/include/asm/arch-npcm8xx/rst.h   |  32 +++
> >>>    arch/arm/mach-nuvoton/Kconfig             |  24 ++
> >>>    arch/arm/mach-nuvoton/Makefile            |   1 +
> >>>    arch/arm/mach-nuvoton/npcm8xx/Kconfig     |  18 ++
> >>>    arch/arm/mach-nuvoton/npcm8xx/Makefile    |   1 +
> >>>    arch/arm/mach-nuvoton/npcm8xx/cpu.c       | 170 ++++++++++++
> >>>    arch/arm/mach-nuvoton/npcm8xx/reset.c     |  51 ++++
> >>>    board/nuvoton/arbel/Kconfig               |  18 ++
> >>>    board/nuvoton/arbel/Makefile              |   1 +
> >>>    board/nuvoton/arbel/arbel.c               |  33 +++
> >>>    include/configs/arbel.h                   |  54 ++++
> >>>    17 files changed, 924 insertions(+)
> > Hello World!
> >
> > Because I was CC'ed I guess I will keep myself up-to date.
> > This commit has 17 files changed and almost 1k insertions,
> > That is a relatively large commit. Would it be better to split
> > /arch/arm/include/asm
> > /arch/arm/mach-nuvoton
> > /board
> > /include/configs
> > into different commits.
> > I ask this because I split them for a patch I'm working on
>
> Please submit the relevant headers with their drivers.
>
> For example, arch/arm/include/asm/arch-npcm8xx/gpio.h should go
> in "[PATCH v1 5/9] gpio: npcm: Add support for Nuvoton NPCM SoCs"
>
> --Sean
>