[PATCH v2 2/2] clk: imx8mq: Add a clock driver for the imx8mq

[Marek Vasut]

On 3/11/22 18:02, Angus Ainslie wrote:
> On 2022-03-11 08:57, Marek Vasut wrote:
>> On 3/11/22 17:35, Angus Ainslie wrote:
>>> This is a DM clock drvier based off the imx8mm u-boot driver and the 
>>> linux
>>> kernel driver.
>>
>> s at drvier@driver@
>>
> Thanks

Sure

>>> All of the PLLs and clocks are initialized so the subsystems below are
>>> functional and tested.
>>>
>>> 1) USB host and peripheral
>>> 2) ECSPI
>>> 3) UART
>>> 4) I2C all busses
>>> 5) USDHC for eMMC support
>>> 6) USB storage
>>> 7) GPIO
>>> 8) DRAM
>>>
>>> The PLL rate tables are from the kernel
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=43cdaa1567ad3931fbde438853947d45238cc040 
>>>
>>
>> That patch is three years old.
>> That patch is for MX8M Mini clock, not for MX8M(Q).
>>
>> You can use the abbreviated commit ID instead:
>> 43cdaa1567ad3 ("clk: imx8mm: Move 1443X/1416X PLL clock structure to 
>> common place")
>> But that seems to be the wrong commit.
> 
> That's the commit where the imx8m PLL frequency table is moved to a 
> common file for use by all of the imx8m variants. The imx8mq linux 
> driver does not even use the frequency tables so there is not a specific 
> commit for it.

Isn't large part of this driver coming from these tables ?

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/log/drivers/clk/imx/clk-imx8mq.c