[PATCH] video: sandbox: fix missing shim definition of sandbox_sdl_remove_display()
sjg at chromium.org
Sat Mar 12 06:02:36 CET 2022
On Fri, 11 Mar 2022 at 11:52, Vladimir Oltean <vladimir.oltean at nxp.com> wrote:
> When CONFIG_SANDBOX_SDL=n, sandbox_sdl_set_bpp() from drivers/video/sandbox_sdl.c
> calls sandbox_sdl_remove_display() in arch/sandbox/cpu/sdl.c, but this
> isn't compiled in. A shim definition is missing, leading to a
> compilation warning (missing function prototype) and a linkage bug.
> Fixes: 8657ad43f353 ("sandbox: video: Add BMP tests for 32bpp and 8bpp modes")
> Signed-off-by: Vladimir Oltean <vladimir.oltean at nxp.com>
> I see Simon's email on the list from January 10 saying:
> | I see that I broke it...it needs a static inline for
> | sandbox_sdl_remove_display().
> but I'm looking at the current 'master' and 'next' branches and that bug
> is still there, huh. Am I missing something?
> arch/sandbox/include/asm/sdl.h | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Simon Glass <sjg at chromium.org>
More information about the U-Boot