[PATCH v3 22/26] rockchip: evb-rk3288: Drop raw-image support

[Simon Glass]

Hi Alper,

On Thu, 10 Mar 2022 at 12:36, Alper Nebi Yasak <alpernebiyasak at gmail.com> wrote:
>
> On 06/03/2022 06:19, Simon Glass wrote:
> > This boards uses SPL_FIT so does not need to support loading a raw image.
>
> This sounds OK to me, but...
>
> > Drop it to avoid binman trying to insert a symbol which has no value.
>
> I couldn't figure out how it leads to this in the code. I guess some
> ifdefs or optimization steps dropping the binman symbols from the ELF file?

Well the raw-image method uses a symbol in SPL which holds the
image-pos of U-Boot. If we disable that, then the symbol is not used
and we don't have to set it. See spl_ram_load_image().

>
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > (no changes since v1)
> >
> >  configs/evb-rk3288_defconfig | 1 +
> >  1 file changed, 1 insertion(+)
>
> Anyway, I have no experience with this board or with loading raw images,
> I barely have a working knowledge of binman symbols, so I'm refraining
> from adding Reviewed-by etc. (in case you were waiting for that).

Sure, thanks for looking at all this. I'll get it in shortly and we
can figure out where to go from there.

Regards,
Simon