[PATCH v2 1/1] cmd: add serial console support for the cls command

[Simon Glass]

Hi Heinrich,

On Fri, 11 Mar 2022 at 00:06, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> On 2/11/22 21:29, Simon Glass wrote:
> > On Fri, 11 Feb 2022 at 10:11, Heinrich Schuchardt
> > <heinrich.schuchardt at canonical.com> wrote:
> >>
> >> Currently the cls command does not support the serial console
> >>
> >> The screen can be cleared in the video uclass, the colored frame buffer
> >> console, and the serial console by sending the same escape sequence.
> >> This reduces the cls command to a single printf() statement on most
> >> boards.
> >>
> >> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> >> ---
> >> v2:
> >>          support cls with CONFIG_DM_VIDEO=y and CONFIG_VIDEO_ANSI=n
> >> ---
> >>   cmd/cls.c | 8 ++++++--
> >>   1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > (would be better with if() instead of #if)
>
> This is not possible because you chose to give two functions with a
> different number of parameters the same name (video_clear()).

Yes that is bad, but I sent a series to remove cfb_console:

https://patchwork.ozlabs.org/project/uboot/list/?series=282367

Regards,
Simon