[PATCH v3 1/6] rockchip: move ROCKCHIP_STIMER_BASE to Kconfig

[Kever Yang]

Hi Johan,

On 2022/3/12 18:01, Johan Jonker wrote:
>
> On 3/12/22 09:51, Jagan Teki wrote:
>> On Thu, Dec 30, 2021 at 10:18 PM Johan Jonker<jbx6244 at gmail.com>  wrote:
>>> Move ROCKCHIP_STIMER_BASE to Kconfig.
>>>
>>> Signed-off-by: Johan Jonker<jbx6244 at gmail.com>
>>> ---
>>>
>>> Changed V3:
>>>    add ROCKCHIP_STIMER
>>> ---
>>>   arch/arm/mach-rockchip/Kconfig        | 22 ++++++++++++++++++++++
>>>   arch/arm/mach-rockchip/px30/Kconfig   |  3 +++
>>>   arch/arm/mach-rockchip/rk3036/Kconfig |  3 +++
>>>   arch/arm/mach-rockchip/rk3128/Kconfig |  3 +++
>>>   arch/arm/mach-rockchip/rk322x/Kconfig |  3 +++
>>>   arch/arm/mach-rockchip/rk3288/Kconfig |  3 +++
>>>   arch/arm/mach-rockchip/rk3308/Kconfig | 10 ++++++----
>>>   arch/arm/mach-rockchip/rk3328/Kconfig |  3 +++
>>>   arch/arm/mach-rockchip/rk3368/Kconfig |  3 +++
>>>   arch/arm/mach-rockchip/rk3399/Kconfig |  3 +++
>>>   arch/arm/mach-rockchip/rk3568/Kconfig |  3 +++
>>>   include/configs/px30_common.h         |  1 -
>>>   include/configs/rk3036_common.h       |  1 -
>>>   include/configs/rk3128_common.h       |  1 -
>>>   include/configs/rk322x_common.h       |  1 -
>>>   include/configs/rk3288_common.h       |  1 -
>>>   include/configs/rk3308_common.h       |  1 -
>>>   include/configs/rk3328_common.h       |  1 -
>>>   include/configs/rk3368_common.h       |  1 -
>>>   include/configs/rk3399_common.h       |  1 -
>>>   include/configs/rk3568_common.h       |  1 -
>>>   21 files changed, 55 insertions(+), 14 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-rockchip/Kconfig b/arch/arm/mach-rockchip/Kconfig
>>> index da6871eb..7a624c64 100644
>>> --- a/arch/arm/mach-rockchip/Kconfig
>>> +++ b/arch/arm/mach-rockchip/Kconfig
>>> @@ -343,6 +343,28 @@ config ROCKCHIP_BOOT_MODE_REG
>>>            The Soc will enter to different boot mode(defined in asm/arch-rockchip/boot_mode.h)
>>>            according to the value from this register.
>>>
>>> +config ROCKCHIP_STIMER
>>> +       bool "Rockchip STIMER support"
>>> +       default y
>>> +       depends on (ROCKCHIP_PX30||   \
>>> +                   ROCKCHIP_RK3036|| \
>>> +                   ROCKCHIP_RK3128|| \
>>> +                   ROCKCHIP_RK322X|| \
>>> +                   ROCKCHIP_RK3288|| \
>>> +                   ROCKCHIP_RK3308|| \
>>> +                   ROCKCHIP_RK3328|| \
>>> +                   ROCKCHIP_RK3368|| \
>>> +                   ROCKCHIP_RK3399|| \
>>> +                   ROCKCHIP_RK3568)
>> What if we select !(SOC-Which-don't-support-stimer). I believe the
>> condition check here is much simpler.
> The condition would be simpler that's correct, but this patch is made
> with rk3066 in mind and there's no ROCKCHIP_RK3066 available yet.
> The right approach is to only include SoC's that have a specific
> property/functionality linked to there specific config tag.
> U-boot should be generic. And we should not have to fix all dependencies
> all over the place when a SoC doesn't have something.
>
> Please advise how to support other SoC's like rk3066.
Thanks for you hard working on this, would you mind to share what's the 
motivation for support rk3066 and MK808 board?
RK3066 is an SoC release at 2012, which has been EOL for a long time, 
and MK808 is a product at 2013, almost 10 years ago.


I'm not object for enable more SoC support on the mainline, and I know 
you have spend a lot
of time on this, I have do something like this before, but to be honest 
I don't think it's a good idea to add support for
rk3066 on mainline now.


I merge the patches from Paweł Jarosz many years ago into rockchip local 
u-boot and make it work,
I want to make the branch support as much SoCs as possible at that time. 
But later I found there is no people to use
it, and the U-Boot is getting more and more heavy, old SoC support is 
the one part people want to clean,
for it always bring in more '#if, #else' or something like this clean up 
series patches, and more terrible thing is how to
always maintain the source code works on the old hardware. I do make 
everything work for a long time at first,
but one day my only rk3066 board is broken, and I'm not able to do it 
anymore.

Thanks,
- Kever
> Johan
>
>> Jagan.