[PATCH 2/2] board: tbs2910: Convert to DM_SERIAL

[Simon Glass]

Hi Soeren,

On Mon, 14 Mar 2022 at 02:26, Soeren Moch <smoch at web.de> wrote:
>
> ... to get rid of the build warning.
> Unfortunately we still need the board specific serial pin init code.
> Otherwise the first boot messages over the serial console are lost.
>
> Signed-off-by: Soeren Moch <smoch at web.de>
> ---
> Cc: Stefano Babic <sbabic at denx.de>
> Cc: Fabio Estevam <festevam at gmail.com>
> Cc: Tom Rini <trini at konsulko.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: u-boot at lists.denx.de
>
> The whole purpose of DM is somewhat defeated when we still need board
> specific initializations. Any ideas how we can get all boot messages
> without board specific inits? 'u-boot,dm-pre-reloc;' in the uart device
> tree node did not help.

You can put that in your serial driver, perhaps? Or in the initial SoC
init code?

Another recent way (in -next) is to use events to monitor the
EVT_DM_PRE_PROBE event for the serial driver.

> ---
>  configs/tbs2910_defconfig | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Simon Glass <sjg at chromium.org>


>
> diff --git a/configs/tbs2910_defconfig b/configs/tbs2910_defconfig
> index 8a33160564..79454053b0 100644
> --- a/configs/tbs2910_defconfig
> +++ b/configs/tbs2910_defconfig
> @@ -81,6 +81,8 @@ CONFIG_PINCTRL=y
>  CONFIG_PINCTRL_IMX6=y
>  CONFIG_DM_RTC=y
>  CONFIG_RTC_DS1307=y
> +CONFIG_DM_SERIAL=y
> +CONFIG_SERIAL_RX_BUFFER=y
>  CONFIG_MXC_UART=y
>  CONFIG_DM_THERMAL=y
>  CONFIG_IMX_THERMAL=y
> --
> 2.25.1
>