[PATCH v3 1/4] rockchip: gru: Set up SoC IO domain registers

Simon Glass sjg at chromium.org
Mon Mar 14 23:20:42 CET 2022


On Mon, 14 Mar 2022 at 15:32, Alper Nebi Yasak <alpernebiyasak at gmail.com> wrote:
> On 11/03/2022 22:49, Jagan Teki wrote:
> > On Fri, Dec 24, 2021 at 7:14 PM Alper Nebi Yasak
> > <alpernebiyasak at gmail.com> wrote:
> >>
> >> The RK3399 SoC needs to know the voltage value provided by some
> >> regulators, which is done by setting relevant register bits. Configure
> >> these the way other RK3399 boards do, but with the same values as are
> >> set in the equivalent code in coreboot.
> >>
> >> Signed-off-by: Alper Nebi Yasak <alpernebiyasak at gmail.com>
> >> Reviewed-by: Kever Yang <kever.yang at rock-chips.com>
> >> ---
> >> There is a driver for this on Rockchip's repo, I managed to forward-port
> >> it and get it working. If that's more desirable than doing it per-board
> >> like this I can send that upstream (but I'd prefer to do it after this).
> >>
> >> [...]
> >
> > This looks like a board hack code for me, which is difficult to
> > maintain in the long run. Better go with UCLASS_POWER_DOMAIN, I
> > believe it would be a straightforward implementation.
> Yeah, it's a board hack that several other boards also do. I've got a
> driver working for this as mentioned above, but that adds a new
> UCLASS_IO_DOMAIN instead of using UCLASS_POWER_DOMAIN like you suggest.
> I had been tired of carrying these patches, so wanted to get any working
> version merged before attempting to upstream the driver and remove the
> hacky parts from all boards at once. I'm not sure how long would that
> take, and I didn't want this to be blocked by that.

+1 let's get this merged as I have been waiting two releases for this
now. I can't really test anything since the base hardware is not
functional on mainline.

> I've got to work on binman things for a while, so I might not be able to
> get to that and your other suggestions soon enough.


More information about the U-Boot mailing list