[PATCH v4 2/4] clk: imx8mq: Add a clock driver for the imx8mq

[Angus Ainslie]

On 2022-03-15 08:46, Angus Ainslie wrote:
>
> Hi Heiko,
>
> On 2022-03-15 08:35, Heiko Thiery wrote:
>> Hi Angus and all,
>>
>>
>>
>>
>> Am Di., 15. März 2022 um 14:09 Uhr schrieb Angus Ainslie 
>> <angus at akkea.ca>:
>>
>>     This is a DM clock driver based off the imx8mm u-boot driver and
>>     the linux
>>     kernel driver.
>>
>>     All of the PLLs and clocks are initialized so the subsystems
>>     below are
>>     functional and tested.
>>
>>     1) USB host and peripheral
>>     2) ECSPI
>>     3) UART
>>     4) I2C all busses
>>     5) USDHC for eMMC support
>>     6) USB storage
>>     7) GPIO
>>     8) DRAM
>>
>>
> Snip
>>
>> when adding this patch and enabling CLK_IMX8MQ I see the following on 
>> my board .. Any idea what I missed here?
>>
>> --- >8 ---
>> U-Boot SPL 2022.04-rc4-00008-g390d9bf9a1 (Mar 15 2022 - 16:26:59 +0100)
>> Trying to boot from SD card
>>
>>
>> U-Boot 2022.04-rc4-00008-g390d9bf9a1 (Mar 15 2022 - 16:26:59 +0100)
>>
>> CPU:   Freescale i.MX8MQ rev2.1 at 800 MHz
>> Reset cause: POR
>> Model: Kontron pITX-imx8m
>> DRAM:  alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> alloc space exhausted
>> 4 GiB
>
> My guess is that there was static code that was setting up the DRAM 
> pll that isn't get executed now that there's a DM clock driver.
>
> I'd try enabling DEBUG in the clk-uclass and clk-composite drivers.
>
> Also look at what DRAM initialization code is not being run now. Our 
> board doesn't have an DRAM specific initialization so there could be a 
> bug in the DRAM setup.
>
>> clk_register: failed to get <NULL> device (parent of ckil)
>> clk_register: failed to get <NULL> device (parent of sys1_pll)
>> clk_register: failed to get <NULL> device (parent of sys2_pll)
>> clk_register: failed to get <NULL> device (parent of sys3_pll)
>
> These are warnings and shouldn't affect the functioning of the driver.
>
>
>> No serial driver found
>
> Are you using the DM serial driver ?
>
> Again this is not something that is running on our board. But I can 
> try enabling it.
>
With DM_SERIAL enabled and SPL_DM_SERIAL disabled

U-Boot SPL 2022.04-rc3-00076-gb363332dc70-dirty (Mar 15 2022 - 09:09:24 
-0700) [0/1906]
Initializing pinmux
Initializing ECSPI
Initializing DRAM
USB Boot
Trying to boot from USB SDP
board_usb_init : index 0 type 1
SDP: initialize...
SDP: handle requests...
Downloading file of size 868420 to 0x40400000... done
Jumping to header at 0x40400000
Header Tag is not an IMX image
Found header at 0x40406e00
board_usb_cleanup : 0
Status: -108


U-Boot 2022.04-rc3-00076-gb363332dc70-dirty (Mar 15 2022 - 09:09:24 -0700)

CPU:   Freescale i.MX8MQ rev2.1 1500 MHz (running at 1000 MHz)
CPU:   Commercial temperature grade (0C to 95C) at 60C
Reset cause: POR
Model: Purism Librem 5r4
DRAM:  3 GiB
Enabling regulator-hub
clk_register: failed to get <NULL> device (parent of ckil)
clk_register: failed to get <NULL> device (parent of sys1_pll)
clk_register: failed to get <NULL> device (parent of sys2_pll)
clk_register: failed to get <NULL> device (parent of sys3_pll)
tps65982 boot successful
Core:  178 devices, 23 uclasses, devicetree: separate
MMC:   FSL_SDHC: 0, FSL_SDHC: 1
Loading Environment from MMC... *** Warning - bad CRC, using default 
environment

In:    serial
Out:   serial
Err:   serial

BuildInfo:
  - ATF 1fd3ff8

Board name: librem5
Board rev:  4
USB Boot
vol_down_key_pressed : 1
Net:   No ethernet found.
Hit any key to stop autoboot:  0


> Thanks
>
> Angus
>
>> resetting ...
>>
>> --- >8 ---
>>
>> -- 
>> Heiko