[PATCH] efi_loader: Use sysreset instead of reset command

Simon Glass sjg at chromium.org
Tue Mar 15 18:46:43 CET 2022


 On Mon, 14 Mar 2022 at 18:43, Masami Hiramatsu
<masami.hiramatsu at linaro.org> wrote:
>
> Use sysreset_walk_halt() directly from reset-after-capsule-on-disk
> feature to reboot (cold reset) machine instead of using reset command
> interface, since this is not a command.
>
> Signed-off-by: Masami Hiramatsu <masami.hiramatsu at linaro.org>
> ---
>  lib/efi_loader/efi_capsule.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


>
> diff --git a/lib/efi_loader/efi_capsule.c b/lib/efi_loader/efi_capsule.c
> index 613b531b82..35907ad0d2 100644
> --- a/lib/efi_loader/efi_capsule.c
> +++ b/lib/efi_loader/efi_capsule.c
> @@ -1150,9 +1150,9 @@ efi_status_t efi_launch_capsules(void)
>          * UEFI spec requires to reset system after complete processing capsule
>          * update on the storage.
>          */
> -       log_info("Reboot after firmware update");
> +       log_info("Reboot after firmware update.\n");
>         /* Cold reset is required for loading the new firmware. */
> -       do_reset(NULL, 0, 0, NULL);
> +       sysreset_walk_halt(SYSRESET_COLD);
>         hang();
>         /* not reach here */
>
>


More information about the U-Boot mailing list