[PATCH] mmc: xenon_sdhci: remove wait_dat0 SDHCI OP

Jaehoon Chung jh80.chung at samsung.com
Wed Mar 16 08:48:27 CET 2022


On 3/15/22 21:22, Tom Rini wrote:
> On Tue, Mar 15, 2022 at 10:47:57AM +0100, Robert Marko wrote:
>> On Mon, Mar 14, 2022 at 2:10 PM Tom Rini <trini at konsulko.com> wrote:
>>>
>>> On Mon, Mar 14, 2022 at 06:37:02PM +0900, Jaehoon Chung wrote:
>>>> On 3/12/22 03:14, Robert Marko wrote:
>>>>> Generic SDHCI driver received support for checking the busy status by
>>>>> polling the DAT[0] level instead of waiting for the worst MMC switch time.
>>>>>
>>>>> Unfortunately, it appears that this does not work for Xenon controllers
>>>>> despite being a part of the standard SDHCI registers and the Armada 3720
>>>>> datasheet itself telling that BIT(20) is useful for detecting the DAT[0]
>>>>> busy signal.
>>>>>
>>>>> I have tried increasing the timeout value, but I have newer managed to
>>>>> catch DAT_LEVEL bits change from 0 at all.
>>>>>
>>>>> This issue appears to hit most if not all SoC-s supported by Xenon driver,
>>>>> at least A3720, A8040 and CN9130 have non working eMMC currently.
>>>>>
>>>>> So, until a better solution is found drop the wait_dat0 OP for Xenon.
>>>>> I was able to only test it on A3720, but it should work for others as well.
>>>>>
>>>>> Fixes: 40e6f52454fc ("drivers: mmc: Add wait_dat0 support for sdhci driver")
>>>>> Signed-off-by: Robert Marko <robert.marko at sartura.hr>
>>>>
>>>> Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>
>>>
>>> Since this is a regression fix, will this be in the PR with the imx fix
>>> as well?  Thanks!
>>
>> Hi Tom,
>> Was this question directed at me or?
> 
> Sorry, to Jaehoon or Peng.

Applied u-boot-mmc, Thanks! Sorry for late.

Best Regards,
Jaehoon Chung

> 



More information about the U-Boot mailing list