[EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job ring driver model

Thu Mar 17 13:10:00 CET 2022

Hello Michael

A gentle reminder!!
As you said earlier, can you test the mamoj board with proposed solution to fix SPL size issue.

Regards
Gaurav Jain

> -----Original Message-----
> From: Gaurav Jain
> Sent: Monday, March 14, 2022 11:18 AM
> To: Michael Nazzareno Trimarchi <michael at amarulasolutions.com>; Stefano
> Babic <sbabic at denx.de>
> Cc: Tom Rini <trini at konsulko.com>; Fabio Estevam <festevam at gmail.com>;
> Michael Walle <michael at walle.cc>; Varun Sethi <V.Sethi at nxp.com>; Adrian
> Alonso <adrian.alonso at nxp.com>; Alison Wang <alison.wang at nxp.com>;
> Andy Tang <andy.tang at nxp.com>; Franck Lenormand
> <franck.lenormand at nxp.com>; Horia Geanta <horia.geanta at nxp.com>; Ji
> Luo <ji.luo at nxp.com>; marex at denx.de; Meenakshi Aggarwal
> <meenakshi.aggarwal at nxp.com>; Mingkai Hu <mingkai.hu at nxp.com>;
> olteanv at gmail.com; Pankaj Gupta <pankaj.gupta at nxp.com>; Peng Fan
> <peng.fan at nxp.com>; Pramod Kumar <pramod.kumar_1 at nxp.com>;
> Priyanka Jain <priyanka.jain at nxp.com>; Rajesh Bhagat
> <rajesh.bhagat at nxp.com>; Sahil Malhotra <sahil.malhotra at nxp.com>;
> Shengzhou Liu <shengzhou.liu at nxp.com>; Silvano Di Ninno
> <silvano.dininno at nxp.com>; sjg at chromium.org; u-boot at lists.denx.de; dl-
> uboot-imx <uboot-imx at nxp.com>; Wasim Khan <wasim.khan at nxp.com>;
> Ye Li <ye.li at nxp.com>; Raffaele RECALCATI <raffaele.recalcati at bticino.it>;
> Jagan Teki <jagan at amarulasolutions.com>
> Subject: RE: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for CAAM Job
> ring driver model
> 
> Hi Michael
> 
> > -----Original Message-----
> > From: Michael Nazzareno Trimarchi <michael at amarulasolutions.com>
> > Sent: Tuesday, March 8, 2022 7:05 PM
> > To: Stefano Babic <sbabic at denx.de>
> > Cc: Tom Rini <trini at konsulko.com>; Fabio Estevam
> <festevam at gmail.com>;
> > Gaurav Jain <gaurav.jain at nxp.com>; Michael Walle <michael at walle.cc>;
> > Varun Sethi <V.Sethi at nxp.com>; Adrian Alonso <adrian.alonso at nxp.com>;
> > Alison Wang <alison.wang at nxp.com>; Andy Tang <andy.tang at nxp.com>;
> > Franck Lenormand <franck.lenormand at nxp.com>; Horia Geanta
> > <horia.geanta at nxp.com>; Ji Luo <ji.luo at nxp.com>; marex at denx.de;
> > Meenakshi Aggarwal <meenakshi.aggarwal at nxp.com>; Mingkai Hu
> > <mingkai.hu at nxp.com>; olteanv at gmail.com; Pankaj Gupta
> > <pankaj.gupta at nxp.com>; Peng Fan <peng.fan at nxp.com>; Pramod Kumar
> > <pramod.kumar_1 at nxp.com>; Priyanka Jain <priyanka.jain at nxp.com>;
> > Rajesh Bhagat <rajesh.bhagat at nxp.com>; Sahil Malhotra
> > <sahil.malhotra at nxp.com>; Shengzhou Liu <shengzhou.liu at nxp.com>;
> > Silvano Di Ninno <silvano.dininno at nxp.com>; sjg at chromium.org; u-
> > boot at lists.denx.de; dl-uboot-imx <uboot-imx at nxp.com>; Wasim Khan
> > <wasim.khan at nxp.com>; Ye Li <ye.li at nxp.com>; Raffaele RECALCATI
> > <raffaele.recalcati at bticino.it>; Jagan Teki
> > <jagan at amarulasolutions.com>
> > Subject: Re: [EXT] Re: [PATCH v8 01/15] crypto/fsl: Add support for
> > CAAM Job ring driver model
> >
> > Caution: EXT Email
> >
> > Hi
> >
> > On Tue, Mar 8, 2022 at 2:28 PM Stefano Babic <sbabic at denx.de> wrote:
> > >
> > > Hi Tom,
> > >
> > > On 08.03.22 13:48, Tom Rini wrote:
> > > > On Tue, Mar 08, 2022 at 08:12:27AM -0300, Fabio Estevam wrote:
> > > >> On Tue, Mar 8, 2022 at 8:10 AM Gaurav Jain <gaurav.jain at nxp.com>
> > wrote:
> > > >>
> > > >>> I further checked on your concern and propose the below change
> > > >>> to
> > stop building caam driver in SPL for imx6dl_mamoj.
> > > >>>
> > > >>> --- a/configs/imx6dl_mamoj_defconfig
> > > >>> +++ b/configs/imx6dl_mamoj_defconfig
> > > >>> @@ -61,3 +61,4 @@ CONFIG_USB_GADGET_MANUFACTURER="FSL"
> > > >>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0525
> > > >>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xa4a5
> > > >>>   CONFIG_CI_UDC=y
> > > >>> +CONFIG_SPL_CRYPTO=n
> > > >>
> > > >> No, this is not how defconfig works.
> > > >>
> > > >> You should set:
> > > >>
> > > >> # CONFIG_SPL_CRYPTO is not set
> > > >
> > > > But more, WHY is this the right answer?  You're disabling
> > > > functionality and the board maintainers aren't even on the CC list
> > > > for this thread it looks like.
> > >
> > > This was my blocking point, too, for this series. There is no answer
> > > about the board.
> > >
> > > I can just imagine (as for other MX6DL) that the required
> > > functionality is secure boot, then CONFIG_IMX_HAB is enough. But
> > > well, just the board maintainers can say. Added Raffaele and Jagan
> > > as reported maintainers for this board.
> > >
> > > >  Why are you not fixing the board so it still links?  What makes
> > > > this board a problem that other (I assume) imx6dl boards are not?
> > >
> > > Well, this board has, compared to other MX6DL, a lot of SPL_ option
> > > that are bloating the SPL size. And then does not match anymore with
> > > the internal RAm, while other MX6DL boards are not so affected by
> > > the increased size because they have no SPL at all or SPL with less
> > > options and then smaller. We do not need to fix the link, but reduce
> > > the size, and nobody else than the maintainers can tell us if
> > > removing some feature is ok.
> > >
> >
> > I will test this week, and try to find a board here to test
> >
> > * Jagan * Do you have a momoj?
> 
> Have you tested mamoj board?
> 
> Regards
> Gaurav
> >
> > Michael
> >
> > > Regards,
> > > Stefano
> > >
> > > --
> > >
> >
> ================================================================
> > =====
> > > DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> > > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell,
> > > Germany
> > > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email:
> > > sbabic at denx.de
> > >
> >
> ================================================================
> > =====
> >
> >
> >
> > --
> > Michael Nazzareno Trimarchi
> > Co-Founder & Chief Executive Officer
> > M. +39 347 913 2170
> > michael at amarulasolutions.com
> > __________________________________
> >
> > Amarula Solutions BV
> > Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172
> > info at amarulasolutions.com
> >
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.a
> > marulasolutions.com%2F&data=04%7C01%7Cgaurav.jain%40nxp.com%
> >
> 7C843e57f75346449f13ae08da010867b6%7C686ea1d3bc2b4c6fa92cd99c5c3
> >
> 01635%7C0%7C0%7C637823432854617357%7CUnknown%7CTWFpbGZsb3d8
> >
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3
> >
> D%7C3000&sdata=f025HmlIM8FuTEYspDjwOevTT1k7JRZeIiS%2FpTH2hc
> > Y%3D&reserved=0