[PATCH v13 1/2] net: Add TCP protocol

[Ramon Fried]

On Wed, Mar 16, 2022 at 8:02 AM Ying-Chun Liu <grandpaul at gmail.com> wrote:
>
> From: "Ying-Chun Liu (PaulLiu)" <paul.liu at linaro.org>
>
> Currently file transfers are done using tftp or NFS both
> over udp. This requires a request to be sent from client
> (u-boot) to the boot server.
>
> The current standard is TCP with selective acknowledgment.
>
> Signed-off-by: Duncan Hare <DH at Synoia.com>
> Signed-off-by: Duncan Hare <DuncanCHare at yahoo.com>
> Signed-off-by: Ying-Chun Liu (PaulLiu) <paul.liu at linaro.org>
> Cc: Christian Gmeiner <christian.gmeiner at gmail.com>
> Cc: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Ramon Fried <rfried.dev at gmail.com>
> ---
> v13: Fix some issues which is reviewed by Christian
> ---

Hi Ying,
You woke up an old can, Can you elaborate on the changes you did to
the original patchset ?
I'm reviewing this instead of Joe, so I want to get some context.

I would appreciate it if you could separate the SACK support to a
separate patch, preferably option based.
The TCP stack is complicated enough and will require a lot of
tinkering / bug fixing in the future. It's best if we could turn
on/off specific RFC which are not originally part of the TCP protocol.

Thanks,
Ramon