[PATCH 0/4] Add support for sam9x60_curiosity

[Eugen.Hristev at microchip.com]

On 3/22/22 10:51 AM, Durai Manickam KR wrote:
> This patch series adds support for sam9x60_curiosity.
> 
> Durai Manickam KR (4):
>    board: Add sam9x60_curiosity support
>    ARM: dts: Add device tree files for sam9x60_curiosity
>    configs: Add sam9x60_curiosity_mmc_defconfig
>    configs: Add sam9x60_curiosity_nandflash_defconfig
> 
>   arch/arm/dts/Makefile                         |   2 +
>   .../dts/at91-sam9x60_curiosity-u-boot.dtsi    |  79 ++++++++++
>   arch/arm/dts/at91-sam9x60_curiosity.dts       |  74 ++++++++++
>   arch/arm/mach-at91/Kconfig                    |   7 +
>   board/atmel/sam9x60_curiosity/Kconfig         |  15 ++
>   board/atmel/sam9x60_curiosity/MAINTAINERS     |   8 +
>   board/atmel/sam9x60_curiosity/Makefile        |   7 +
>   .../sam9x60_curiosity/sam9x60_curiosity.c     | 139 ++++++++++++++++++
>   configs/sam9x60_curiosity_mmc_defconfig       |  82 +++++++++++
>   configs/sam9x60_curiosity_nandflash_defconfig |  82 +++++++++++
>   include/configs/sam9x60_curiosity.h           |  67 +++++++++
>   11 files changed, 562 insertions(+)
>   create mode 100644 arch/arm/dts/at91-sam9x60_curiosity-u-boot.dtsi
>   create mode 100644 arch/arm/dts/at91-sam9x60_curiosity.dts
>   create mode 100644 board/atmel/sam9x60_curiosity/Kconfig
>   create mode 100644 board/atmel/sam9x60_curiosity/MAINTAINERS
>   create mode 100644 board/atmel/sam9x60_curiosity/Makefile
>   create mode 100644 board/atmel/sam9x60_curiosity/sam9x60_curiosity.c
>   create mode 100644 configs/sam9x60_curiosity_mmc_defconfig
>   create mode 100644 configs/sam9x60_curiosity_nandflash_defconfig
>   create mode 100644 include/configs/sam9x60_curiosity.h
> 

Hello Durai,

Please send incremental versions of your patches from now on. This is 
the version 2, and also include changes from previous versions in the 
cover letter or the patch itself under the three dashes (---) .

Other than that, running your patches through the automated CI/CD loop, 
it looks like unmigrated symbols are no longer accepted into U-boot. 
(symbols that are defined in board files with '#define CONFIG_***' 
instead of having them as Kconfig symbols and selected through defconfig 
or other symbols)

The problem is in the header sam9x60_curiosity.h header file.
I tried to chop it down to see which of the symbols are unaccepted, and 
I have come up with the following file with looks to be accepted by the 
script:

/* start of file */

#ifndef __CONFIG_H__ 

#define __CONFIG_H__ 

 

#define CONFIG_SYS_AT91_SLOW_CLOCK      32768 

#define CONFIG_SYS_AT91_MAIN_CLOCK      24000000        /* 24 MHz 
crystal */
 

#define CONFIG_USART_BASE   ATMEL_BASE_DBGU 

#define CONFIG_USART_ID     0 /* ignored in arm */ 

 

/* SDRAM */ 

#define CONFIG_SYS_SDRAM_BASE           0x20000000 

#define CONFIG_SYS_SDRAM_SIZE           0x8000000       /* 128 MB */ 

 

#ifdef CONFIG_SPL_BUILD 

#define CONFIG_SYS_INIT_SP_ADDR         0x218000 

#else 

#define CONFIG_SYS_INIT_SP_ADDR \ 

         (CONFIG_SYS_SDRAM_BASE + 16 * 1024 + CONFIG_SYS_MALLOC_F_LEN - 
\
          GENERATED_GBL_DATA_SIZE) 

#endif 

 

#endif

/* end of file */

So the other symbols you are defining in this file are no longer accepted.
So you have to find some solution to use migrated symbols instead of 
defining them in the board file. If some are mandatory for board 
operations, they would require migration first (I have not checked if 
some others are already migrated )
Otherwise, the board cannot go into u-boot mainline at the moment.

Eugen