[PATCH 1/2] net: dsa: fix phydev->speed being uninitialized for the CPU port fixed PHY

Vladimir Oltean vladimir.oltean at nxp.com
Fri Mar 25 19:07:06 CET 2022

Hi Tim,

On Fri, Mar 25, 2022 at 09:53:20AM -0700, Tim Harvey wrote:
> Vladimir,
> I came across this while looking for the best place to configure cpu
> port interface mode (ie rgmii id) for the mv88e61xx dsa driver I'm
> working on. Note that this patch causes port_probe to be called on the
> cpu port 'before' the master device has been probed. I'm not sure if
> this is intended or not?
> In my case I was looking to configure the cpu port interface mode when
> the port was probed but I can't do that because it happens before the
> switch is probed because of some things that need to happen there.
> Best Regards,
> Tim

You're past the DM_MDIO probing issues now? Glad to hear that.
Probing the DSA CPU port before the master wasn't necessarily the
intention, but then again, I'm not sure that there's a strict ordering
guarantee between the two that needs to be satisfied?

What do you need exactly? We could probably always reverse the
device_probe(master) call with the probing of the CPU port if the
ordering turns out to be a real problem. I can regression-test the
change on my boards, but I'd like to understand the need you have, maybe
even document it so that future changes are aware of it.

More information about the U-Boot mailing list