[PATCH v2] boot: image: fixup zstd decompression buffer initialization typo

Tom Rini trini at konsulko.com
Mon Mar 28 16:16:00 CEST 2022


On Wed, Mar 16, 2022 at 03:35:36PM -0400, Jérôme Carretero wrote:

> The code was mistakenly initializing the input buffer twice.
> 
> Tested to be working on BeagleBone by adjusting CONFIG_SYS_BOOTM_LEN to
> 64MiB (probably works with less) and preparing uImage with:
> 
>  cat arch/arm/boot/Image \
>   | zstd --ultra -22 --zstd=windowLog=22 \
>   > linux.bin.zst
> 
>  mkimage -A arm -T kernel uImage -C zstd -d linux.bin.zst \
>   -a 0x80008000 -e 0x80008000
> 
> Without the windowLog restriction, bootm fails with a zstd decompression
> error 7 (window too large), which I haven't troubleshooted.
> 
> There should be a bit more documentation on the feature...
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Fixes: 458b30af66c image: Update image_decomp() to avoid ifdefs

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20220328/0a71d1b6/attachment.sig>


More information about the U-Boot mailing list