Layerscape DM_SERIAL (Was: Re: [PATCH v3 16/29] serial: Add semihosting driver)

[Sean Anderson]

Hi Tom,

On 3/28/22 12:03 PM, Tom Rini wrote:
> On Mon, Mar 28, 2022 at 11:36:46AM -0400, Sean Anderson wrote:
>> On 3/28/22 2:35 AM, Simon Glass wrote:
>>  
>> > But please can we drop the non-DM support?
>> 
>> Unfortunately, Layerscape does not support DM serial. I tried converting
>> it, but I ran into some unusual aborts. At the moment, I don't have time
>> to debug things further. And I thought that non-DM serial was ok for
>> SPL?
> 
> It is OK for SPL, and it needs migration for non-SPL.  Can you make
> another thread with your conversion-that-fails for layerscape please?
> 

Unfortunately, I didn't save my attempt. I believe it's just

diff --git a/include/configs/ls1046a_common.h b/include/configs/ls1046a_common.h
index 7552610e03..f7aaddd98c 100644
--- a/include/configs/ls1046a_common.h
+++ b/include/configs/ls1046a_common.h
@@ -48,8 +48,10 @@
 #define COUNTER_FREQUENCY              25000000        /* 25MHz */
 
 /* Serial Port */
+#if !CONFIG_IS_ENABLED(DM_SERIAL)
 #define CONFIG_SYS_NS16550_SERIAL
 #define CONFIG_SYS_NS16550_REG_SIZE    1
+#endif
 #define CONFIG_SYS_NS16550_CLK          (get_serial_clock())
 
 /* SD boot SPL */
--

plus enabling the appropriate configs. I think I was using CONFIG_DM_SERIAL
and possibly CONFIG_NS16550_DYNAMIC.

--Sean