[PATCH] mmc: rockchip_sdhci: Correct error checking

Jaehoon Chung jh80.chung at samsung.com
Tue Mar 29 01:14:02 CEST 2022


On 3/22/22 21:58, li.haolin at qq.com wrote:
> From: Haolin Li <li.haolin at qq.com>
> 
> A pointer can not be negative. Use macro IS_ERR_OR_NULL() for checking.
> 
> Signed-off-by: Haolin Li <li.haolin at qq.com>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  drivers/mmc/rockchip_sdhci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/rockchip_sdhci.c b/drivers/mmc/rockchip_sdhci.c
> index f3f9d83ba3..a46895299d 100644
> --- a/drivers/mmc/rockchip_sdhci.c
> +++ b/drivers/mmc/rockchip_sdhci.c
> @@ -227,7 +227,7 @@ static int rk3399_emmc_get_phy(struct udevice *dev)
>  	}
>  
>  	grf_base = syscon_get_first_range(ROCKCHIP_SYSCON_GRF);
> -	if (grf_base < 0) {
> +	if (IS_ERR_OR_NULL(grf_base)) {
>  		printf("%s Get syscon grf failed", __func__);
>  		return -ENODEV;
>  	}



More information about the U-Boot mailing list