[PATCH] mtd: rawnand: mxs_nand: Fix use_minimum_ecc for spl driver

Fabio Estevam festevam at gmail.com
Tue Mar 29 16:05:26 CEST 2022


Hi Ye Li,

On Tue, Mar 29, 2022 at 5:38 AM Ye Li <ye.li at nxp.com> wrote:
>
> Because mxs_nand_spl driver does not support DM, to use the minimum ECC
> layout, it needs to handle the CONFIG_NAND_MXS_USE_MINIMUM_ECC.
>
> Signed-off-by: Ye Li <ye.li at nxp.com>
> ---
>  drivers/mtd/nand/raw/mxs_nand.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/mxs_nand.c b/drivers/mtd/nand/raw/mxs_nand.c
> index ee5d7fd..28e189a 100644
> --- a/drivers/mtd/nand/raw/mxs_nand.c
> +++ b/drivers/mtd/nand/raw/mxs_nand.c
> @@ -1380,6 +1380,10 @@ int mxs_nand_init_spl(struct nand_chip *nand)
>         else
>                 nand_info->max_ecc_strength_supported = 40;
>
> +#ifdef CONFIG_NAND_MXS_USE_MINIMUM_ECC
> +       nand_info->use_minimum_ecc = true;
> +#endif

Please use if (IS_ENABLED(CONFIG_NAND_MXS_USE_MINIMUM_ECC)) as
suggested by checkpatch:

WARNING: Use 'if (IS_ENABLED(CONFIG...))' instead of '#if or #ifdef'
where possible
#17: FILE: drivers/mtd/nand/raw/mxs_nand.c:1383:
+#ifdef CONFIG_NAND_MXS_USE_MINIMUM_ECC

Thanks


More information about the U-Boot mailing list